大家看看，是不是我寫的有問題，里面回圈讀取呼叫資料至少三次
public string getOneRoomOnePriceListByPage(int houseid, int bid = 0, int uid = 0,int HouseTypeID=0, int pageindex = 1, int pagesize = 10)
{
int erro =1;
JObject jOb = new JObject();
ArrayList List = new ArrayList();
int totalCount = 0;
DataTable dt = AppWXsource.getOneRoomOnePriceListPageByHouseID(houseid);
DataRow[] drArr = null;
if (dt != null&&dt.Rows.Count>0)
{
erro = 1;
if (bid == 0 && uid == 0 && HouseTypeID == 0)
drArr = dt.Select("HouseID=" + houseid);//查詢
else if (bid != 0 && uid == 0 && HouseTypeID == 0)
drArr = dt.Select("BuildingID=" + bid);//查詢
else if (bid != 0 && uid != 0 && HouseTypeID == 0)
drArr = dt.Select("UnitID=" + uid+ " and BuildingID=" + bid);//查詢
else if (bid != 0 && uid != 0 && HouseTypeID != 0)
drArr = dt.Select("HouseTypeID=" + HouseTypeID+ " and UnitID = " + uid + " and BuildingID=" + bid);//查詢
if (drArr==null||drArr.Length<=0)
{
jOb.Add(new JProperty("total", totalCount));
jOb.Add(new JProperty("list", List));
return JsonDo.JobjectToJson(jOb,erro, "沒有相關的記錄");
}
totalCount = drArr.Length;//取得總數
int pagenum = 1;
int lastnum = 0;
pagenum = pagesize * (pageindex - 1);
if ((pagenum + pagesize) > totalCount)
lastnum = totalCount;
else
lastnum = pagenum + pagesize;
for (int i= pagenum; i < lastnum; i++)
{
DataRow rs = drArr[i];
//取得房號，房號戶型ID
int RoomID =(int)rs["RoomID"];
string RoomNum = "";
string Rooms = "";
string Halls = "";
string Floors = "";
DataTable Rtd = new DAL.AppWX.room().getRoomAndHouseTypeInfoByRoomID(RoomID);
if(Rtd!=null&&Rtd.Rows.Count>0)
{
RoomNum = Rtd.Rows[0]["RoomNum"].ToString();
Rooms = Rtd.Rows[0]["Rooms"].ToString();
Halls = Rtd.Rows[0]["Halls"].ToString();
Floors = Rtd.Rows[0]["Floors"].ToString();
}
JObject jObj = new JObject();
jObj.Add(new JProperty("SourceID", rs["SourceID"]));
jObj.Add(new JProperty("RoomNum", RoomNum));
var SourceTag = rs["SourceTag"].ToString();
if (SourceTag != "")
{
SourceTag = SourceTag.TrimEnd(',');
SourceTag = new BLL.Source().GetOneHouseAllTagsName(SourceTag.Trim());
}
jObj.Add(new JProperty("SourceTag", SourceTag));
//讀取戶型資料
string Tid = rs["HouseTypeID"].ToString();
string typeinfo = "";
typeinfo = Rooms + "房" + Halls + "廳";
jObj.Add(new JProperty("housetypes", typeinfo));
jObj.Add(new JProperty("CoveredArea", rs["CoveredArea"]));
jObj.Add(new JProperty("Floors", Floors));
float a = 0;
float b = 0;
float totprice = 0;
float oneprice = 0;
try
{
a = float.Parse(rs["SourcePrice"].ToString());
b = float.Parse(rs["CoveredArea"].ToString());
int pricetype = int.Parse(rs["pricetype"].ToString());
if (pricetype == 2)//2為單價
{
totprice = a * b;
oneprice = a;
}
else
{
totprice = a;
oneprice = a / b;
}
}
catch
{
//
}
//取得房源首圖
string SourceImg = "";
int SourceID = int.Parse(rs["sourceID"].ToString());
DataTable dtImg = AppWXsource.getSourceImg(SourceID);
if (dtImg.Rows.Count > 0)
{
SourceImg = ImageUrl + dtImg.Rows[0]["ThumbnailName"].ToString();
}
else
{
//如果房源圖片為空，則調取戶型圖
int houseTypeID = Common.Util.ConvertInt32(rs["HouseTypeID"], 0);
DataTable dtHouseTypeImg = new DAL.House().GetPhotoByHouseType(houseTypeID);
if (dtHouseTypeImg != null && dtHouseTypeImg.Rows.Count > 0)
{
SourceImg = ImageUrl + dtHouseTypeImg.Rows[0]["ThumbnailName"].ToString();
}
}
jObj.Add(new JProperty("SourceImg", SourceImg));
jObj.Add(new JProperty("oneprice", oneprice));
jObj.Add(new JProperty("totprice", totprice));
jObj.Add(new JProperty("IsOnline", rs["IsOnline"]));
jObj.Add(new JProperty("IsSold", rs["IsSold"]));
jObj.Add(new JProperty("HouseTypeID", rs["HouseTypeID"]));
//取得多少棟多少單元多少房號
DataTable dtS = AppWXsource.getHouseNameBuildingNameUnitNameRoomNum(RoomID);
if (dtS.Rows.Count > 0)
{
jObj.Add(new JProperty("HouseName", dtS.Rows[0]["HouseName"]));
jObj.Add(new JProperty("BuildingName", dtS.Rows[0]["BuildingName"]));
jObj.Add(new JProperty("UnitName", dtS.Rows[0]["UnitName"]));
}
List.Add(jObj);
}
}
jOb.Add(new JProperty("total", totalCount));
jOb.Add(new JProperty("list", List));
return JsonDo.JobjectToJson(jOb, erro);
}
uj5u.com熱心網友回復：
這個函式一看兩百行，連看你代碼的興趣都沒了。uj5u.com熱心網友回復：
同意樓上意見.你把代碼優化下,單個函式代碼控制在20行以內,并對函式取有意義的名稱.你做完這些,你的問題可能就已經解決了.
轉載請註明出處，本文鏈接：https://www.uj5u.com/net/247884.html
標籤：C#
上一篇：想實作個功能，來求助大佬